Ensure that changes to a room's `is_direct` status gets propagated to the RoomsList

[kevinaboos]

If the is_direct status of a room changes for some reason (for example, if member changes cause the SDK’s is_direct() return value to change, or if the m.direct tag is modified), the current update_room logic does not seem to detect this specific change and send a dedicated update to RoomsList to adjust the grouping of that room.

Let's fix it in the future pr.

Originally posted by @aaravlu in #471 (comment)

[emmettlu]

I have figured this issue out with Alvin, our worry for this is redundant.

Whether one room is direct or not is influenced by many factors, such as the userself, the acsess the user get into the room, etc.

How the user comming into the room is one of the factors.

Once some user joined some room, the direct attribute of the room would never change for this user.

e.g., some room may be direct for user A but non-direct for user B. (I fully tested using 3 matrix accounts)

Whether one room is direct or not for some user is a very complex question, but it is fully handled by matrix rust sdk, which means sdk has done its best so nothing for us to do here.

---

The direct property could be changed.

[kevinaboos]

Hmm, I don't necessarily agree with that conclusion.

I'm not saying we have to discover other ways of determining if a room is direct. If the sdk says it's direct, then that is all we need to worry about.

This issue is ahout whether a change to the room being considered direct or not will be properly handled by Robrix. For example, if Robrix is opened and a given room is marked as direct, but then the same user uses a different client (like Element) to change the status of that room from direct to non-direct, will Robrix automatically update that room's status and handle all of the UI changes properly?

[emmettlu]

I'm not saying we have to discover other ways of determining if a room is direct. If the sdk says it's direct, then that is all we need to worry about.

You're absolutely correct, it's perfectly possible to manually mark a room as direct or non-direct.(I have asked people in Matrix Rust SDK room.)

Element doesn't yet offer this feature in the UI (this may be a trap to confuse) but FluffyChat could.

It's always good to be careful.

[kevinaboos]

I saw your messages on the SDK room, thanks for reaching out to the sdk devs to confirm! I wasnt sure, so I'm glad we double checked.

Sounds like you can just test by opening Robrix, using a different client to change a room's direct status, and then see what Robrix does. It might already just work due to how the room list service emits an update any time the state of a room changes.

We'll eventually add a UI widget to allow the user to change room state, such as tags, direct, etc. But that is a future concern. For now, we should just ensure that Robrix correctly handles changes in room state made by other clients, not within Robrix itself.

[emmettlu]

Blocked because matrix-sdk is old that robrix relies on, e.g., TimelineItemContent in matrix_sdk_ui::timeline::event_item::content is not implmented for AnyGlobalAccountDataEventContent, which contains the m.direct event in ruma_events::enums.

[kevinaboos]

We're now updated to the latest matrix-sdk version, so this is ready to be worked on.