Conversation
mhellmeier
left a comment
There was a problem hiding this comment.
Great work, @eschrewe! Most things already worked for me, but I have a couple of improvements.
edc-controlplane/edc-controlplane-construct-x/local/additional_config/vault-init.sh
Show resolved
Hide resolved
...t-x/local/bruno/con-x-local-test/identities/Inspect Outcome/ShowProviderCredentials copy.bru
Outdated
Show resolved
Hide resolved
...ne-construct-x/local/bruno/con-x-local-test/identities/Simulated DCP Flow/Get Credential.bru
Show resolved
Hide resolved
...ntrolplane-construct-x/local/bruno/con-x-local-test/identities/Simulated DCP Flow/folder.bru
Show resolved
Hide resolved
|
I was able to start the local Docker Compose based testing environment. However, I wasn’t able to verify all of the functionality in the Bruno collection. Since I haven’t worked with the EDC code before, I was only able to perform limited black box testing due to the size of the PR. For future changes, I would really appreciate it if we could keep PRs smaller, especially for people who are new to the project. |
Smaller PRs are definitely the plan. This PR is huge due to the initialization and the export of the Bruno collection. But thanks a lot for your feedback and black box testing! |
|
I did execute the full sequence, which resulted in a successful asset exchange. However, I am not familiar enough with the domain to thoroughly assess the correctness of the payloads and responses. |
|
I also tried to execute the full sequence, but ran into problems during the After initiating the transfer process via the bruno request, the provider-dataplane shows the following error: This error results in a severe error in the provider-controlplane: I am not sure whether this is a problem of the branch or on my side, but since others got it to work properly it may be a problem of my local build environment. Unfortunately i am not familiar enough with the vault and the edc, to dig deeper into this. For reference: |
Hi @tloebbert , during the past days, I was in contact with some other people, who had similar-looking error messages. And in the end we managed to debug this for their particular cases. The learnings from these debugging sessions resulted in some more commits to this branch in the past days. So the first thing I would like to ask you to do is: Please do a to make sure are testing on the latest version. Then, please let me know if the problem still shows up. (If yes, I'd propose we then try to arrange a Teams-Meeting in order to find a solution.) Best regards |
|
Hi @eschrewe
i just pulled the latest bruno collection update, restarted the docker container and did the test again. Unfortunately, the issue was not resolved.
I think this is a good idea! Best regards |
Just sent you an email. |
Hi @tloebbert , thanks for the productive meeting this morning. We just added something which hopefully makes sure, that these CRLF troubles in the vault-init script can't happen any more. Please test and let me know. :) BR |
|
Hi @eschrewe, thank you too for your input! So everything looks good to me :) Best regards |
WHAT
WHY
enable testing and usage of edc-based data exchange
FURTHER NOTES
Closes CXAP4-117