refactor: use an SVG image for the "what diagram"#899
Merged
Conversation
|
♻️ PR Preview 35f63d8 has been successfully destroyed since this PR has been closed. 🤖 By surge-preview |
2 tasks
csouchet
approved these changes
Feb 22, 2023
Contributor
csouchet
left a comment
There was a problem hiding this comment.
Good for a first version.
Should be improved later 🙂
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

As this is a vector image, the quality will be better on all devices, especially on large ones.
The image wasn't up-to-date: the overlays on edges were sometimes wrongly positioned. This was a bug in
bpmn-visualizationand it was fixed several months ago.Notes
SVG export done using the content of process-analytics/bpmn-visualization-examples#464.
The exported command was the following (using html2svg v1.0.0)
See process-analytics/bpmn-visualization-tools#18 for more details.
To review
Image processing impact --> to be tested with a local Lighthouse check: ✔️ no new issue!