Skip to content

[DOC] Fix the actions to do to set the development version #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
csouchet wants to merge 2 commits into from
Closed

[DOC] Fix the actions to do to set the development version #146

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cc9cd3
Fix the actions to do to set the development version
csouchet Nov 18, 2022
5bd408a
Merge remote-tracking branch 'origin/main' into fix_maintainer_doc
csouchet Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,11 @@ if some files require changes. The PR/commit message should be `[RELEASE] Set ve

**NOTE**: this is a very manual process today. For improvements, see [#131](https://github.com/process-analytics/bpmn-visualization-R/issues/131)

Update the [DESCRIPTION](./DESCRIPTION) file to use a development version (for more explanations, see the [R documentation](https://r-pkgs.org/release.html#post-release):
- bump the current version. For instance, if the released version was `0.3.0`, bump it to `0.3.1`
- add a postfix to the version to state that it is a development version. For instance, `0.3.1.9000`
Add the `.9000` suffix to the `Version` field in the [DESCRIPTION](./DESCRIPTION) file to indicate that this is a development version (for more explanations, see the [R documentation](https://r-pkgs.org/release.html#post-release)).
For instance, if the released version was `0.3.0`, the `Version` field in the `DESCRIPTION` file should be `0.3.O.9000`.
Copy link
Member

@tbouffard tbouffard Nov 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be what is described in the R documentation, but I disagree. This tends to say version 0.3.0 is under development whereas it has just been released.
This is always the same issue with build solution that stores the version number in a file. We always have to figure out what the version in the development branch means: is it the last release one, the next one, something else, .... 😞

Let's talk about it because you may have implemented this in #145.
That's being said, updating the documentation whereas we are automating the whole thing seems useless.


Create a new PR (it must have the `skip-changelog` label as we don't want it to appear in the release notes) and merge it.
The PR/commit message should be `[INFRA] Set the development version to x.y.z`.
The PR/commit message should be `[INFRA] Set the development version to x.y.z.9000`.

### Publish the new version on CRAN

Expand Down