Fix miles estimate reactivity to slippage changes#93
Merged
passandscore merged 3 commits intomainfrom Apr 1, 2026
Merged
Conversation
Miles estimation now recomputes when slippage changes, not just amountOut, since slippage directly determines the MEV opportunity and resulting miles. Also guards computedMinAmountOut against NaN reaching BigInt when the user types a partial decimal (e.g. "0.") in the slippage input.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…gas pricing
- Convert miles calculation from useEffect to useMemo for synchronous updates
when slippage or amountOut changes (no more 1-frame delay)
- Use median of 5-block priority fee instead of single-block sample to smooth
out gas price spikes that caused miles to drop to 0
- Snapshot gas data in refs so background 12s fee ticks don't trigger
unnecessary recalculations — only user-driven changes do
- Guard against BigInt(NaN) crash by using validateSlippage() for all
slippage→BigInt conversions in use-swap-quote
- Skip quote recalculation for transient/invalid slippage values ("", ".", "0")
- Validate amount is numeric before enabling quote fetch
- Guard displayQuote.amountOut type before BigInt arithmetic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
computedMinAmountOutagainstNaNreachingBigIntwhen the user types a partial decimal (e.g. "0.") in the slippage inputTest plan