fix: normalize array-shaped tags before PATCHing order to OS - #34
Merged
Conversation
return_prime_public's markOsOrderReturned.js builds tags as a JS array
(buildReturnedTags dedupes into [...new Set([...])]), but OS's
UpdateOrderDto types tags as a comma-separated string and throws an
unhandled 500 ("An error occurred while updating the order") on an
array instead of a clean 400 — confirmed live against OS directly with
the identical array payload.
Verified: wrote a test reproducing the exact 500 first (failed against
the unfixed code), fixed by joining array tags into a comma-separated
string before forwarding, then confirmed live through the full adapter
path against a real order (200, tags applied).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
return_prime_public's markOsOrderReturned.js builds tags as a JS array (buildReturnedTags dedupes into [...new Set([...])]), but OS's UpdateOrderDto types tags as a comma-separated string and throws an unhandled 500 ("An error occurred while updating the order") on an array instead of a clean 400 — confirmed live against OS directly with the identical array payload.
Verified: wrote a test reproducing the exact 500 first (failed against the unfixed code), fixed by joining array tags into a comma-separated string before forwarding, then confirmed live through the full adapter path against a real order (200, tags applied).