Return Prime app (adapter module) - #17
Merged
Merged
Conversation
OS orders never populate a real transactions array, so RP's GET /rp/shopify/orders/:id/transactions always returned empty regardless of whether the order was COD or prepaid — RP's COD-detection logic reads this endpoint and was defaulting every OS order to COD. Now derives a single Shopify-shaped transaction from the order's own financial_status/payment_details when it indicates a captured payment.
- rp-sdk: zero-markup storefront integration — auto-detects order pages and injects Return/Exchange buttons + a /apps/return_prime page filler, with an enable/disable check and a portal iframe - webhooks: handle OS app/uninstalled — deactivate the adapter's own merchant record and relay to RP's new os-uninstall endpoint, closing the gap where an uninstalled OS store kept working indefinitely - transformer: set inventory_management: null on OS variants so RP's checkBlocked() doesn't mark every OS product unconditionally blocked - portal: resolve order name from a bare orderId for the SDK, but never resolve email/phone from orderId alone (no ownership proof) — matches RP's existing require-caller-supplied-email model, avoids a PII oracle - admin-rp: fix onboarding snippet to use VITE_API_BASE_URL (was referencing a nonexistent env var, breaking every new merchant's copy-pasted script tag by default) - config/sdk: wildcard CORS on the public config + SDK bundle endpoints
…adapter # Conflicts: # apps/backend/test/unit/meta/catalog-source-paging.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.