This repository was archived by the owner on Aug 14, 2025. It is now read-only.
Change all test output to exported preCICE output only#256
Merged
Conversation
Eder-K
added a commit
that referenced
this pull request
Oct 24, 2020
* Update installed OF version (v5 -> v2006) * Source new of bashrc file * Update openfoam path * Enable output for OF tests * Install fenics from default ubuntu package * Update reference for OFv2006 * Allow fenics to fail * Use 'pimpleFoam' in line with OF version update * Update reference * Add 'build_info.py' * Add test folder for 20.04 deal.ii-of * Update reference * Update reference * Improve text filter * Fix numeric error in comparison * Update error message on missing entries * Change all test output to exported preCICE output only (#256) * Change to VTK exported preCICE output * Enable output for all tests * Use automatic dependency install * Use 'make all check' * Add PKG_CONFIG_PATH * Fix typo * Fix unused flag * Fix sed pattern * Update reference * Fix typo * Update reference * Use manual fenics install * Update reference * Update reference * Update reference * Filter hexadecimals * Update reference * Skip 'events-summary' type files * Update reference * Fix unfinished if clause * Move log filtering into systemtesting * Use glob for searching logfiles * Fix module error * Print debug output * Remove ignored logs * Update reference * Format debug print * Allow su2-ccx 20.04 to fail * Add seperate test folder for su2-ccx 2004 * Check exponent instead of full number * Update reference
Eder-K
added a commit
that referenced
this pull request
Oct 24, 2020
* Add precice builds for Ubuntu 20.04 * Add travis jobs for 20.04 and 16.04 package * Fix indent * Add 20.04 to accepted versions * Adjust boost install * Make sure install process is noninteractive * Clear up comments * Make terminal noninteractive * Add adapter/test builds for 20.04 * Remove deploy section * Move docker login step into scripts * Add Ubuntu2004 to accepted versions * Simplify push.py call * Add missing logs folder * Use 'build_info.py' file to transfer information * Fix indent * Fix typo * Import common * use repr to capture string delimiters * Fix bracket * Remove undefined reference * Fix folder creation * Allow ccx adapter 20.04 to fail * Improve error messages * Enable output for 1dtube * Adjust installed spooles package * Add non-PETSc builds * Save build info before attempting build * Correct image version for ccx-adapter * Remove unused return arguments * Ignore both 'e' and 'E' from text comparison * Disable output * Clean up 20.04 builds * Install petsc from apt * Fix typo * Replace 'is' with '==' * Fix empty arg error * Install python3 * Use 20.04 solver version for 20.04 deal.ii adapter * Add base_solver as optional argument * Upgrade from OpenFOAM 5 to OpenFOAM v2006 (#255) * Update installed OF version (v5 -> v2006) * Source new of bashrc file * Update openfoam path * Enable output for OF tests * Install fenics from default ubuntu package * Update reference for OFv2006 * Allow fenics to fail * Use 'pimpleFoam' in line with OF version update * Update reference * Add 'build_info.py' * Add test folder for 20.04 deal.ii-of * Update reference * Update reference * Improve text filter * Fix numeric error in comparison * Update error message on missing entries * Change all test output to exported preCICE output only (#256) * Change to VTK exported preCICE output * Enable output for all tests * Use automatic dependency install * Use 'make all check' * Add PKG_CONFIG_PATH * Fix typo * Fix unused flag * Fix sed pattern * Update reference * Fix typo * Update reference * Use manual fenics install * Update reference * Update reference * Update reference * Filter hexadecimals * Update reference * Skip 'events-summary' type files * Update reference * Fix unfinished if clause * Move log filtering into systemtesting * Use glob for searching logfiles * Fix module error * Print debug output * Remove ignored logs * Update reference * Format debug print * Allow su2-ccx 20.04 to fail * Add seperate test folder for su2-ccx 2004 * Check exponent instead of full number * Update reference * Disable debug output
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252 .
This PR adjusts the output of all tests. Every participant now produces an additional output folder
precice-outputcontaining coupling data (see in https://github.com/precice/precice/wiki/Exports-Configuration).When comparing to reference files, now only logfiles and the new
precice-outputwill be considered.To accomodate for the changed output, other adjustments have been made to several scripts:
The systemtesting.py script will deliberately ingore
...-events-summary.logandldd.logfiles when starting a file comparison. This is done with a list of regex patterns which can be adjusted in the future.The comparison bash script now checks if a numeric value is sufficiently large before attempting to compare. Currently, the threshold is set to 10E-12, values below that will be assumed to be zero and thus ignored.