Skip to content
This repository was archived by the owner on Aug 14, 2025. It is now read-only.

remove old python bindings#123

Merged
fsimonis merged 4 commits into
developfrom
compatibility_PR_576_on_precice_core
Dec 2, 2019
Merged

remove old python bindings#123
fsimonis merged 4 commits into
developfrom
compatibility_PR_576_on_precice_core

Conversation

@BenjaminRodenberg
Copy link
Copy Markdown

@BenjaminRodenberg BenjaminRodenberg commented Nov 26, 2019

@BenjaminRodenberg
Copy link
Copy Markdown
Author

This test does not succeed, because it uses precice/precice:develop and not precice/precice:i_511.

@BenjaminRodenberg
Copy link
Copy Markdown
Author

precice/tutorials#58 has to be merged, before we can merge this PR. As soon as precice/tutorials#58 this test is expected to complete successfully.

@BenjaminRodenberg
Copy link
Copy Markdown
Author

From my point of view this PR is ready to merge. There is still one failing test. However, this test was already failing before (see https://travis-ci.org/precice/systemtests/jobs/603688857#L757-L786). We should fix the failing test in a different PR and merge this one. Note: I am preparing a fix in #132.

@fsimonis fsimonis merged commit 96bc064 into develop Dec 2, 2019
@fsimonis fsimonis deleted the compatibility_PR_576_on_precice_core branch December 2, 2019 09:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants