chore(pkg-py): remove stale ggsql casing guidance#226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This is a follow-up to the earlier Python-side ggsql 0.3 prep work in #225.
That upgrade moved QueryChat onto the newer ggsql validation and syntax behavior, but it left behind one stale workaround from the pre-0.3 era: guidance and execution logic that assumed ggsql column references in
VISUALISEwere effectively case-sensitive and therefore needed QueryChat to normalize or teach lowercase aliases.In other words, this is effectively a follow-up to a follow-up:
Current ggsql now handles uppercase column references correctly, so QueryChat no longer needs to:
ROOM_TYPE/lowercase-alias workaroundSummary
Testing