Skip to content

chore(pkg-py): remove stale ggsql casing guidance#226

Merged
cpsievert merged 2 commits intomainfrom
chore/pkg-py-drop-stale-ggsql-casing
Apr 30, 2026
Merged

chore(pkg-py): remove stale ggsql casing guidance#226
cpsievert merged 2 commits intomainfrom
chore/pkg-py-drop-stale-ggsql-casing

Conversation

@cpsievert
Copy link
Copy Markdown
Contributor

@cpsievert cpsievert commented Apr 30, 2026

Context

This is a follow-up to the earlier Python-side ggsql 0.3 prep work in #225.

That upgrade moved QueryChat onto the newer ggsql validation and syntax behavior, but it left behind one stale workaround from the pre-0.3 era: guidance and execution logic that assumed ggsql column references in VISUALISE were effectively case-sensitive and therefore needed QueryChat to normalize or teach lowercase aliases.

In other words, this is effectively a follow-up to a follow-up:

Current ggsql now handles uppercase column references correctly, so QueryChat no longer needs to:

  • lowercase dataframe columns before registering them with ggsql
  • teach the model a special ROOM_TYPE/lowercase-alias workaround
  • repeat the redundant charts-vs-tables note in the ggsql syntax reference

Summary

  • remove the stale column-casing workaround from Python ggsql execution
  • remove obsolete casing/charts-vs-tables guidance from the Python ggsql syntax prompt
  • add regression tests for uppercase column support and prompt cleanup

Testing

  • uv run pytest -q pkg-py/tests/test_viz_tools.py pkg-py/tests/test_ggsql.py -p no:playwright
  • uv run ruff check pkg-py/src/querychat/_viz_ggsql.py pkg-py/tests/test_ggsql.py pkg-py/tests/test_viz_tools.py --config pyproject.toml

@cpsievert cpsievert requested a review from Copilot April 30, 2026 16:46

This comment was marked as resolved.

@cpsievert cpsievert merged commit 985452d into main Apr 30, 2026
7 checks passed
@cpsievert cpsievert deleted the chore/pkg-py-drop-stale-ggsql-casing branch April 30, 2026 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants