-
Notifications
You must be signed in to change notification settings - Fork 139
Remove Copilot SDK and use Copilot Chat for completions #11163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ture/copilot-sdk-begone
|
E2E Tests 🚀 |
|
Lots of changes here so I'm going through some testing locally to see how authentication feels to the user. |
timtmok
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It worked when authenticating using our provider dialog and with the action from the GitHub Pull Requests extension.
This change eliminates Positron's dependence on the Copilot Language Server, and serves completions directly from an updated version of the GitHub Copilot Chat extension.
This solves a number of issues around authentication and feature parity with Copilot completions in VS Code.
Changes are also required to our Copilot Chat fork; see posit-dev/positron-copilot-chat#8.
Addresses #10491
Fixed: Auth state
Auth state is now derived from the built-in Accounts menu, instead of from the token that the LSP writes. This improves auth in remote SSH in particular, since the local authentication session can supply credentials to the chat and completion systems running on the the remote host.
#9811 - show correct state when signing out of copilot
#10365 - remote ssh auth again
#10317 - handle auth for remote ssh sessions
#8409 - also an issue for remote ssh auth
Fixed: Completion behavior
These issues are side effects of using the LSP, and should now be resolved.
#9301 - copilot completions emit a lot of console errors
#10564 - "trigger inline suggestion" command not supported
#11066 - copilot autocomplete does not work
Fixed: Working with a proxy
Now that all network requests are being made by the Copilot extension directly, VS Code's native network settings can be used to configure proxies and custom certificates.
https://docs.github.com/en/copilot/how-tos/configure-personal-settings/configure-network-settings
#8990 - certificate errors with sdk
#11015 - can't sign in to copilot
#8623 - issues signing in with a proxy
Partially fixed
#8775 - too many github sign ins. partially addressed; now copilot chat and completions share a sign in
Release Notes
New Features
Bug Fixes
QA Notes
Test tags:
@:assistant