Skip to content

Conversation

@jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Dec 18, 2025

This change eliminates Positron's dependence on the Copilot Language Server, and serves completions directly from an updated version of the GitHub Copilot Chat extension.

This solves a number of issues around authentication and feature parity with Copilot completions in VS Code.

Changes are also required to our Copilot Chat fork; see posit-dev/positron-copilot-chat#8.

Addresses #10491

Fixed: Auth state

Auth state is now derived from the built-in Accounts menu, instead of from the token that the LSP writes. This improves auth in remote SSH in particular, since the local authentication session can supply credentials to the chat and completion systems running on the the remote host.

#9811 - show correct state when signing out of copilot
#10365 - remote ssh auth again
#10317 - handle auth for remote ssh sessions
#8409 - also an issue for remote ssh auth

Fixed: Completion behavior

These issues are side effects of using the LSP, and should now be resolved.

#9301 - copilot completions emit a lot of console errors
#10564 - "trigger inline suggestion" command not supported
#11066 - copilot autocomplete does not work

Fixed: Working with a proxy

Now that all network requests are being made by the Copilot extension directly, VS Code's native network settings can be used to configure proxies and custom certificates.

https://docs.github.com/en/copilot/how-tos/configure-personal-settings/configure-network-settings

#8990 - certificate errors with sdk
#11015 - can't sign in to copilot
#8623 - issues signing in with a proxy

Partially fixed

#8775 - too many github sign ins. partially addressed; now copilot chat and completions share a sign in

Release Notes

New Features

Bug Fixes

QA Notes

  • You can now sign in or out of Copilot using the Accounts menu in addition to the Positron model config dialog.
  • The Positron model config dialog will let you sign in but not sign out (a limitation of the authentication API). You'll need to sign out from the Accounts menu.
  • An unfortunate side effect of this change is that we are once again using the Code OSS client ID when authenticating, which means that when you perform the auth flow the Github confirmation page will say "Visual Studio Code" of "Positron".

Test tags: @:assistant

@jmcphers jmcphers requested a review from timtmok December 18, 2025 18:51
@github-actions
Copy link

github-actions bot commented Dec 18, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical @:assistant

readme  valid tags

@timtmok
Copy link
Contributor

timtmok commented Dec 19, 2025

Lots of changes here so I'm going through some testing locally to see how authentication feels to the user.

timtmok
timtmok previously approved these changes Jan 5, 2026
Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It worked when authenticating using our provider dialog and with the action from the GitHub Pull Requests extension.

@jmcphers jmcphers merged commit 3290136 into main Jan 6, 2026
12 checks passed
@jmcphers jmcphers deleted the feature/copilot-sdk-begone branch January 6, 2026 01:20
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants