chore: update compatible dependencies#318
Conversation
| }, | ||
| "engines": { | ||
| "node": ">=20" | ||
| "node": ">=20.18.1" |
There was a problem hiding this comment.
This update selects e2b@2.20.1, which now requires Node >=20.18.1, while the repo/package still advertises engines.node: >=20. Because e2b is a production dependency, installs with engine-strict on Node 20.0-20.17 now fail despite being in the supported range. Please either raise the advertised Node engine to >=20.18.1 or keep e2b on a compatible 2.19.x version.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 34a37498f7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| "engines": { | ||
| "node": ">=20" | ||
| "node": ">=20.18.1" | ||
| } |
There was a problem hiding this comment.
This update locks e2b to a release that requires Node >=20.18.1, which narrows runtime compatibility compared with the project’s declared engines.node: >=20 range. In environments that enforce engines (for example npm ci with engine-strict=true), installs on Node 20.0–20.17 will now fail even though those versions are still advertised as supported; either pin e2b to a compatible version or raise the project’s minimum Node version to match.
Useful? React with 👍 / 👎.
| "engines": { | ||
| "node": ">= 20.12.0" | ||
| } |
There was a problem hiding this comment.
The lockfile now resolves @clack/prompts to a version that declares node >=20.12.0, but the project still advertises engines.node: >=20. Because this is a direct runtime dependency of the CLI, installs on Node 20.0–20.11 can fail under engine enforcement (or run with unsupported runtime semantics) despite being documented as supported; pinning to a compatible prompt version or increasing the project’s Node floor avoids that mismatch.
Useful? React with 👍 / 👎.
Summary
Validation
npm run buildnpm run lintnpx turbo run test:unit --concurrency=4 --forcenpx vitest run scripts/postinstall-sync-skills.test.ts