Skip to content

ExaGO ChatGrid Dynamic Loading of JSON Files#203

Draft
maksud wants to merge 6 commits intodevelopfrom
viz/dynamica-json
Draft

ExaGO ChatGrid Dynamic Loading of JSON Files#203
maksud wants to merge 6 commits intodevelopfrom
viz/dynamica-json

Conversation

@maksud
Copy link
Collaborator

@maksud maksud commented Feb 10, 2026

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This MR adds the feature of loading JSON Files into the ChatGrid visualization tool. A user can see a set of pre-configured compatible JSON files for visualization and also an user can upload the json file for visualization.

@pelesh pelesh requested review from pelesh and tsybinae February 10, 2026 22:32
@pelesh pelesh added enhancement New feature or request visualization labels Feb 10, 2026
@pelesh pelesh requested a review from abhyshr February 10, 2026 22:33
Copy link
Collaborator

@pelesh pelesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please update README file with instructions how to use the updated version.
  • Please provide/identify JSON files that can be used out of box.

@pelesh
Copy link
Collaborator

pelesh commented Feb 10, 2026

The update breaks the old process documented in the viz/README file. If I follow that, I get following error:

SyntaxError: The string did not match the expected pattern.

I can still open the file and view the visualization but the error message is confusing and the instructions are misleading.

@pelesh
Copy link
Collaborator

pelesh commented Feb 10, 2026

The color scheme for transmission lines seems to be broken. Most of the lines are in black, which is not in the legend. This needs to be fixed before merging. Please follow @tsybinae recommendation there. I will mark this as draft until we fix the outstanding issues.

@pelesh pelesh marked this pull request as draft February 10, 2026 22:59
@pelesh
Copy link
Collaborator

pelesh commented Feb 10, 2026

It is great that separated active and reactive power flow are shown separately. I suggest renaming "Power flow" to active power flow. Instead of animation, I suggest adding arrows to show direction of the power flow.

@maksud
Copy link
Collaborator Author

maksud commented Feb 12, 2026

The update breaks the old process documented in the viz/README file. If I follow that, I get following error:

SyntaxError: The string did not match the expected pattern.

I can still open the file and view the visualization but the error message is confusing and the instructions are misleading.

There was a static list of file files that is assumed to be in the data folder. Replaced it using a dynamic list which will list all json files in the data folder. The json files in the data folders will be assumed to contain only compatible visualized json case files. I have moved counties.json file to another folder so all json files in the data folder is a valid case file.

@maksud
Copy link
Collaborator Author

maksud commented Feb 12, 2026

The color scheme for transmission lines seems to be broken. Most of the lines are in black, which is not in the legend. This needs to be fixed before merging. Please follow @tsybinae recommendation there. I will mark this as draft until we fix the outstanding issues.

I don't seem to reproduce this issue. Maybe the updates pushed to this branch will fix this.

@maksud
Copy link
Collaborator Author

maksud commented Feb 12, 2026

It is great that separated active and reactive power flow are shown separately. I suggest renaming "Power flow" to active power flow. Instead of animation, I suggest adding arrows to show direction of the power flow.

This PR was also supposed to show Arrows by default and when you check the Animation, it can turn Arrows to Animation. Please check whether this work as intended. I have renamed "Flow" To "Active Power Flow"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request visualization

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants