Skip to content

Python Router fetch_market_matches routes to deprecated "fetchMatches" sidecar method instead of canonical "fetchMarketMatches" #974

@realfishsam

Description

@realfishsam

Gap

The Python SDK Router.fetch_market_matches() calls the sidecar using the deprecated method name "fetchMatches". The TypeScript SDK Router.fetchMarketMatches() correctly uses the canonical name "fetchMarketMatches". This inconsistency means the Python SDK is one sidecar deprecation-removal away from silently breaking.

Current state

Python SDK (sdks/python/pmxt/router.py:201):

raw = self._call_method("fetchMatches", params)  # deprecated name

TypeScript SDK (sdks/typescript/pmxt/router.ts): uses "fetchMarketMatches" (canonical).

Core (core/src/router/Router.ts): fetchMarketMatches is the canonical method name; fetchMatches is the deprecated alias.

Note: issue #858 tracks the Python Router missing min_difference and sort parameters on this method, but does not cover the method name discrepancy.

Expected behaviour

sdks/python/pmxt/router.py line 201 should call self._call_method("fetchMarketMatches", params) to match the canonical sidecar method name used by the TypeScript SDK.

Impact

If the sidecar ever removes the fetchMatches deprecated alias, Python Router.fetch_market_matches() will break silently (404 or method-not-found). The TypeScript SDK will continue to work.

Metadata

Metadata

Assignees

No one assigned

    Labels

    core-sdk-gapCore engine capabilities not exposed in SDKs

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions