fix(core): fire onRest when animation is cancelled before its first frame#2511
Merged
Conversation
…t frame Closes #1802 `SpringValue._stop` gated `onRest` on `anim.changed`, which only flips to `true` once the first frame has rendered. When two `start()` calls happen within a single tick and the second returns the spring to its current value, the engine stops the animation before any frame fires, so `onRest` was silently dropped. The entry to the block already requires `isAnimating(this)` to be true, so dropping the `anim.changed` guard is safe — it just covers the gap where a spring transitioned active → idle without rendering a frame.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 0d56421 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1802.
Summary
SpringValue._stopgatedonRestonanim.changed, which only flips totrueonce the first frame has rendered. When twostart()calls happen within a single tick and the second returns the spring to its current value, the engine stops the animation before any frame fires — soonRestwas silently dropped while the start promise still resolved. The same gap affectedset()andstop()called synchronously afterstart().Entry to the block already requires
isAnimating(this), so dropping theanim.changedguard just covers the gap where a spring transitioned active → idle without rendering a frame. The full unit suite passes (253 / 0).Repro