Skip to content

test(core): regression tests for issue #1638#2504

Merged
joshuaellis merged 1 commit into
nextfrom
test/gh-1638
May 22, 2026
Merged

test(core): regression tests for issue #1638#2504
joshuaellis merged 1 commit into
nextfrom
test/gh-1638

Conversation

@joshuaellis

Copy link
Copy Markdown
Member

Summary

  • Adds regression tests covering both repro patterns from First render after useLayoutEffect is ignored if animated value evaluated as 0 #1638 (imperative api.start() and declarative state-driven useSpring) where the initial value is 0 and the goal is set in useLayoutEffect.
  • Both scenarios already animate correctly on next (v10.0.4); these tests lock in the behaviour so it can't silently regress under React 19 + StrictMode.

Closes #1638

Add regression tests for issue #1638 covering both imperative
(api.start) and declarative (state-driven) useSpring patterns
where the initial value is 0 and the goal is set in useLayoutEffect.
@vercel

vercel Bot commented May 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-spring Ready Ready Preview May 22, 2026 8:27am

Request Review

@changeset-bot

changeset-bot Bot commented May 22, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0693351

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshuaellis
joshuaellis merged commit 2e5b97a into next May 22, 2026
18 checks passed
@joshuaellis
joshuaellis deleted the test/gh-1638 branch May 22, 2026 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

First render after useLayoutEffect is ignored if animated value evaluated as 0

1 participant