test(types): restore TypeScript 6.0 to CI matrix#2465
Merged
Conversation
Closes #2442 TS 6 deprecated `downlevelIteration` and `baseUrl`, causing `pnpm test:ts` to fail on 6.0. Both options were dead config in this repo: `downlevelIteration` only matters for ES5 targets (repo targets ES2020 with noEmit) and `baseUrl` was unused (no path-based imports relied on it; docs uses its own tsconfig). Dropping them is cleaner than silencing via `ignoreDeprecations`.
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
tsup's dts plugin hardcodes `baseUrl: compilerOptions.baseUrl || "."`, re-injecting the deprecated option even after we removed it from tsconfig.json. TS 6.0 then errors on its own injected value. Conditionally adds `ignoreDeprecations: "6.0"` to tsconfig only for the TS 6.0 matrix entry — earlier matrix versions reject "6.0" as an invalid value (TS5103) so we can't set it unconditionally. Tracks upstream: egoist/tsup#1388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores TypeScript 6.0 to the
test-typesCI matrix by removing two tsconfig options that TS 6 deprecated.Why this works
Both options were dead config:
downlevelIteration— only affects emit fortarget< ES2015; this repo targets ES2020 withnoEmit: true.baseUrl: "./"— nopathsmapping uses it and no source imports rely on baseUrl-rooted resolution.docs/tsconfig.jsonkeeps its ownbaseUrl+pathsfor~/*(separate scope, excluded from root).Dropping them is cleaner than silencing via
ignoreDeprecations, which would just defer the work to TS 7.Verification
pnpm test:tsclean on TS 6.0.3.pnpm test:tsclean on TS 5.7.2 (dev baseline).['5.0', '5.4', '5.7', '5.9', '6.0'].Closes #2442