Old N8AO dependency in package.json is causing Shader Error 0 when three.js > 0.166.0 is installed as well

[ayan4m1]

For context, see N8python/n8ao#32

Basically, postprocessing depends explicitly on a fairly old version of N8AO , which is not compatible with Three.js starting from 0.166.0. This means that if you use the N8AO convenience component in postprocessing, you will get a Shader Error unless you hold three.js back.

I think there are multiple possible solutions here:

1. Kick the can and just bump n8ao to latest in package.json
2. Make n8ao a peerDependency with a semver range like "1.x" and then make the user install/upgrade it on their own
3. Document the bug and do nothing else

My preference would be for the second choice, but obviously open to discussion. Happy to open a PR if there is consensus.

Repro: https://github.com/ayan4m1/leela-memorial (then upgrade three.js to latest and run yarn install, npm start, go to "3D view" page and observe error)

[hallo-yurik]

I have the same error. On version three 0.168.0 "SSAO" doesn't work and after using "N8AO" I get this error

[N8python]

This is because the N8AO they are using is very old :(. 1.9.2 is neccessary.

[CodyJasonBennett]

We're not able to use N8AO upstream since it pulls from three/examples and creates a dual package hazard for us. There is an additional issue of how/whether we update N8AO as it is not backwards compatible.

[github-actions]

🎉 This issue has been resolved in version 2.16.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[ayan4m1]

Appreciate the fix!

[N8python]

Elaborate on what you mean by 'dual package hazard'? How would I alleviate this?

[N8python]

If N8AO was to be entirely self-contained, would this issue be resolved? And an update could be made?

[zr00da]

I'm getting a Shader Error 0 - no default precision defined for variable 'vec2[4]' on r170 with 2.16.3 of this lib, but only on certain devices (Pixel phones) and the whole render goes black. Tried downgrading to r165 but it has the same issue.

edit: I see this is also a known issue with old N8AO version (N8python/n8ao#36), could really use an update here. Hopefully someone can work the hazard out with @N8python as it's one of the most useful filters and it's pretty much unusable as of now when it breaks the render on certain devices.

[ayan4m1]

@zrooda I'm not the author of the lib, but I'm unable to reproduce your issue, see here - this works in Chrome on my Pixel 4a. I have updated three to 0.171.0 and postprocessing to 2.16.3. If you run npm ls n8ao you should see version 1.9.3 - if not, that's your problem.