Implement recent Core updates, fix logger

[bouwew]

Summary by CodeRabbit

Release Notes

• Bug Fixes

  • Improved error logging for sensor entity descriptions.

• Improvements

  • Enhanced device information initialization with manufacturer, model, and version details.
  • Refined schedule entity configuration categorization for better organization.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This pull request updates the Plugwise integration with changelog entries documenting ongoing work, refactors entity initialization to use device-based context instead of data lookups, improves logging in binary sensor setup, and removes the entity_category configuration from the SELECT_SCHEDULE description.

Changes

Cohort / File(s)	Summary
Documentation & Changelog CHANGELOG.md	Added "Ongoing" subsection documenting two Core PR references (#158901, #158094) as ongoing work.
Binary Sensor Logging custom_components/plugwise/binary_sensor.py	Fixed debug logging to use description.translation_key with fallback to description.key, ensuring non-None value in logs when adding binary sensor entities.
Entity Initialization & Device Info custom_components/plugwise/entity.py	Refactored initialization to derive API context and compute configuration_url conditionally for gateway device; replaced data-driven lookups with device-based access; populated device_info from device context (manufacturer, model, versions); added enrichment logic for non-gateway devices to update ATTR_NAME and ATTR_VIA_DEVICE.
Select Entity Configuration custom_components/plugwise/select.py	Removed entity_category argument from SELECT_SCHEDULE description; other entity descriptions retain their entity_category=EntityCategory.CONFIG setting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• entity.py requires careful review of the initialization refactoring, conditional configuration_url logic, and device_info population changes
• binary_sensor.py logging fallback pattern and its integration with the entity setup flow
• Verify that the removal of entity_category from SELECT_SCHEDULE doesn't unintentionally change entity categorization behavior

Possibly related PRs

• Implement HA Core PR 138039 #829: Modifies the same binary_sensor debug logging and adds related changelog entries
• Show configuration_url for gateway only #975: Adjusts entity.py device_info and configuration_url handling for gateway-only display

Suggested labels

downstreaming, quality

Suggested reviewers

• CoMPaTech
• github-actions

Poem

🐰 A refactor so neat, with devices so true,
Device info now gathered from gateways anew,
Logging falls back with grace and with flair,
Config categories pruned with care,
Plugwise integration hops right along! 🎉

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title refers to two main aspects of the changeset: implementing Core updates (entity.py changes) and fixing a logger (binary_sensor.py debug message fix). It accurately summarizes the primary changes.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch follow-core

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b4f3b36 and 339e49f.

📒 Files selected for processing (4)

• CHANGELOG.md (1 hunks)
• custom_components/plugwise/binary_sensor.py (1 hunks)
• custom_components/plugwise/entity.py (1 hunks)
• custom_components/plugwise/select.py (0 hunks)

💤 Files with no reviewable changes (1)

• custom_components/plugwise/select.py

🧰 Additional context used

🧠 Learnings (1)

📓 Common learnings

Learnt from: CoMPaTech
Repo: plugwise/plugwise-beta PR: 0
File: :0-0
Timestamp: 2025-01-25T20:42:24.862Z
Learning: The linting rules in plugwise-beta have been updated to use TC001/TC002/TC003 instead of TCH001/TCH002/TCH003 for type-checking related rules.

🧬 Code graph analysis (2)

custom_components/plugwise/entity.py (1)

tests/components/plugwise/conftest.py (1)

• gateway_id (57-62)

custom_components/plugwise/binary_sensor.py (1)

custom_components/plugwise/entity.py (1)

• device (97-99)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Prepare and validate pre-commit

🔇 Additional comments (6)

custom_components/plugwise/binary_sensor.py (1)

142-142: LGTM! Good defensive programming.

The fallback to description.key when translation_key is None ensures the debug log always contains a meaningful value. This is especially important for entity descriptions like BATTERY_STATE (line 58) that have a device_class but no translation_key.

CHANGELOG.md (1)

5-8: LGTM! Clear documentation of ongoing work.

The new "Ongoing" section provides transparency about work in progress and properly references the relevant Core PRs.

custom_components/plugwise/entity.py (4)

45-54: LGTM! Clean refactoring with proper conditional logic.

The extraction of api, gateway_id, and entry improves code readability. The conditional configuration URL assignment correctly ensures only the gateway device gets a configuration URL, with appropriate existence checks.

---

56-61: LGTM! Clean connection building logic.

The use of the walrus operator with self.device.get() provides a concise and safe pattern for conditionally adding connections only when MAC addresses are present.

---

63-74: The access to api.smile.name at line 71 is safe and does not require a null check.

The api parameter is initialized as a Smile instance in the coordinator's __init__ method, and by the time entity initialization occurs, the coordinator has already completed its first refresh via await coordinator.async_config_entry_first_refresh() in __init__.py. This ensures the connection is established and api.smile is fully populated. The same attribute access pattern (api.smile.name without checks) is used elsewhere in the integration (config_flow.py, init.py) immediately after the first refresh, confirming this is a safe, standard pattern.

---

76-83: No action needed—the implementation is correct and defensive.

The code properly uses self.device.get(ATTR_NAME) to safely handle the device name. This is actually more defensive than necessary: throughout the codebase (climate.py, binary_sensor.py, sensor.py, etc.), the "name" field is accessed directly via device["name"] without defensive checks, confirming that all device objects from the Plugwise API contain a name field. Using .get() here adds an extra layer of safety and is the right approach.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud