Skip to content

Fic(Condition): Fix condition check logic for dropdown field values #953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stonebuzz merged 2 commits into from
May 27, 2025
Merged

Fic(Condition): Fix condition check logic for dropdown field values #953

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6b5c71
Fic(Condition): Fix condition check logic for dropdown field values
stonebuzz May 20, 2025
0c5bcc6
dapat changelog
stonebuzz May 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [UNRELEASE]

### Fixed

- Fix condition check logic for dropdown field values
- Fix validation for mandatory multiple dropdown

## [1.21.21] - 2025-03-21
Expand Down
4 changes: 2 additions & 2 deletions inc/field.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1033,9 +1033,9 @@ function () {
'change',
'input, select, textarea',
function(evt) {
if (evt.target.name == "itilcategories_id") {
if (evt.target.name == "itilcategories_id" && {$items_id} == 0) {
// Do not refresh tab container when form is reloaded
// to prevent issues diues to duplicated calls
// to prevent issues diues to duplicated calls (when object is new)
return;
}
if ($(evt.target).closest('#{$html_id}').length > 0) {
Expand Down