feat: use database transactions for the bulk generation#157
Closed
boazpoolman wants to merge 3 commits intomasterfrom
Closed
feat: use database transactions for the bulk generation#157boazpoolman wants to merge 3 commits intomasterfrom
boazpoolman wants to merge 3 commits intomasterfrom
Conversation
🦋 Changeset detectedLatest commit: 2b1f411 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #157 +/- ##
==========================================
- Coverage 30.21% 30.21% -0.01%
==========================================
Files 4 4
Lines 13968 13975 +7
Branches 4974 4975 +1
==========================================
+ Hits 4221 4223 +2
- Misses 7709 7714 +5
Partials 2038 2038
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Handle bulk generation using database transactions.
Why is it needed?
Because bulk generating the URL aliases could potentially be a very large task. Using database transactions we can assure the database is not in a "half" broken state mid bulk generation.
How to test it?
Test the different features of the bulk generation feature.
Related issue(s)/PR(s)
#13
Todo