Update logging for auth plugin #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BRONSOLO
reviewed
Jun 10, 2025
Member
BRONSOLO
left a comment
There was a problem hiding this comment.
Will this suppress any errors that would be meaningful for the ssh-er to receive? Like if a workspace deploy via ssh fails, would it do so silently now?
Author
|
@BRONSOLO No, I tried that and as a non-licensed user, I get this:
and this in container logs:
so fwiw, it's better than what we had so far. Both the "Authentication" and Authorization errors show up in container logs and Authorization error show up in frontend. authentication here refers to the auth-plugin.. |
Member
|
Oh nice! so it gives us more control even. That rocks. 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances the logging functionality in the auth plugin to improve debugging and monitoring capabilities for the git-ssh-server.
Related Issues
@BRONSOLO Please review when you have a chance.