test: Pass native dataframe in test_pass_df_columns and test_category_order_with_category_as_x
#4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
px.histogram in test_pass_df_columnstest_pass_df_columns and test_category_order_with_category_as_x
Contributor
|
Most likely my bad, nice catch @MarcoGorelli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like in this test a Narwhals DataFrame is being passed to
px.histogram- however, a user would pass in their native frame, not a Narwhals one, so I think the test should be testing whentips.to_native()is passed, not whentipsis passed. At least, that's what all the other tests do - I presume this was an accident? I might be missing something thoughcc @FBruzzesi