-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
Update plotly.js to 2.24.1 and add docs for new features #4210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Excellent. Thank you @LiamConnors 🥇 |
alexcjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
|
Looks like the |
Yeah, looks like something to do with that. |
|
|
||
| *New in 5.15* | ||
|
|
||
| Pie charts support [patterns](/python/pattern-hatching-texture/) (also known as hatching or texture) in addition to color. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's have similar minimal examples for funnelarea, icicle, sunburst and treemap.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
|
@alexcjohnson and @archmoj this is ready for another look. I've updated to Plotly.js 2.24.0 and added examples for patterns for the new trace types. Lots of formatting changes applied by the code generator. Not sure why. |
|
🥇 Looking very good to me. |
Thanks @archmoj. |
alexcjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃 after updating the changelog
Co-authored-by: Alex Johnson <[email protected]>
Documentation PR
doc/README.mdfiledoc-prodbranch OR it targets themasterbranchpxexample if at all possibleplotly.graph_objects as go/plotly.express as px/plotly.io as piodffig = <something>call is high up in each new/modified example (eitherpx.<something>ormake_subplotsorgo.Figure)fig.add_*andfig.update_*rather thango.Figure(data=..., layout=...)in every new/modified examplefig.add_shapeandfig.update_xaxesare used instead of bigfig.update_layoutcalls in every new/modified examplefig.show()is at the end of each new/modified exampleplotly.plot()andplotly.iplot()are not used in any new/modified exampleCode PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
-->