Be more forgiving when anything with opening a webbrowser fails #4161
Conversation
|
@jonmmease I think this is ready for review. Since you have written most of the file I touched, I'm tagging you, but feel free to nominate someone else of course. I don't fully understand the failing release build, but I don't suspect I am causing it. Update: I hovered over your name and it said "Former Chief Scientist at Plotly", so I'm not entirely sure whether you review pull requests still. Maybe let's also tag @chriddyp 😇 |
|
Hi @bartbroere, I'm not a maintainer of plotly projects any more, but FWIW these changes look reasonable to me! |
|
@bartbroere the code change looks great, thanks! Just a couple of comments on the tests. |
Co-authored-by: Alex Johnson <[email protected]>
|
Thanks for the commit bringing it up to date. I might have some time tonight (GMT+2) to finish this PR and apply the feedback. |
|
@alexcjohnson I think it's ready for merge now |
alexcjohnson
left a comment
There was a problem hiding this comment.
💃 Thanks @bartbroere, looks great!
This (hopefully) fixes an issue I encountered with Starboard Notebook. I'll link the issue here.