fix: clean up resize listener when view gets removed #3805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes plotly#3100 If this is not cleaned up, we see a lot of stacktraces in the JS console: index.js?v=20220623202309:2 Uncaught (in promise) Error: Resize must be passed a displayed plot div element. at index.js?v=20220623202309:2:2385247 at new Promise (<anonymous>) at b.resize (index.js?v=20220623202309:2:2385199) at h.autosizeFigure (index.js?v=20220623202309:2:3736430) at index.js?v=20220623202309:2:3736222 Also, the destroy methods is renamed to remove. Destroy will never be called, but remove is.
Contributor
|
Thanks! |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3100
If this is not cleaned up, we see a lot of stacktraces in the JS console:
index.js?v=20220623202309:2 Uncaught (in promise) Error: Resize must be passed a displayed plot div element.
at index.js?v=20220623202309:2:2385247
at new Promise ()
at b.resize (index.js?v=20220623202309:2:2385199)
at h.autosizeFigure (index.js?v=20220623202309:2:3736430)
at index.js?v=20220623202309:2:3736222
Also, the destroy method is renamed to remove. Destroy will never be
called, but remove is.