Skip to content

Correct some regular expression syntax. #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonmmease merged 8 commits into from
Jun 24, 2020
Merged

Correct some regular expression syntax. #2577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b28162
Correct some badly-formed regular expressions.
georgevdd Jun 18, 2020
f291e5e
Correct some badly-formed regular expressions.
georgevdd Jun 18, 2020
514e7fb
Merge branch 'master' of https://github.com/georgevdd/plotly.py
georgevdd Jun 18, 2020
c97d8b0
Merge branch 'master' of https://github.com/georgevdd/plotly.py
georgevdd Jun 18, 2020
24f7e6b
Merge branch 'clean-regex' of https://github.com/georgevdd/plotly.py …
georgevdd Jun 18, 2020
ecb92b0
Merge branch 'clean-regex' of https://github.com/georgevdd/plotly.py …
georgevdd Jun 18, 2020
c14ad82
Merge branch 'clean-regex' of https://github.com/georgevdd/plotly.py …
georgevdd Jun 18, 2020
eb12ec7
Correct some badly string syntax in regular expressions.
georgevdd Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/python/plotly/codegen/datatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class {datatype_class}(_{node.name_base_datatype}):\n"""

import re
_subplotid_prop_re = re.compile(
'^(' + '|'.join(_subplotid_prop_names) + ')(\d+)$')
'^(' + '|'.join(_subplotid_prop_names) + r')(\d+)$')
"""
)

Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/basedatatypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class BaseFigure(object):
Base class for all figure types (both widget and non-widget)
"""

_bracket_re = re.compile("^(.*)\[(\d+)\]$")
_bracket_re = re.compile(r"^(.*)\[(\d+)\]$")

_valid_underscore_properties = {
"error_x": "error-x",
Expand Down
2 changes: 1 addition & 1 deletion packages/python/plotly/plotly/graph_objs/_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class Layout(_BaseLayoutType):

import re

_subplotid_prop_re = re.compile("^(" + "|".join(_subplotid_prop_names) + ")(\d+)$")
_subplotid_prop_re = re.compile("^(" + "|".join(_subplotid_prop_names) + r")(\d+)$")

@property
def _subplotid_validators(self):
Expand Down