Skip to content

Fix for #1809 Python 2.7 incompatibility in the iframe renderer #1810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonmmease merged 1 commit into from
Oct 15, 2019
Merged

Fix for #1809 Python 2.7 incompatibility in the iframe renderer #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/python/plotly/codegen/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
from io import StringIO
from typing import List
import re
import errno


# Source code utilities
Expand All @@ -30,7 +31,11 @@ def write_source_py(py_source, filepath, leading_newlines=0):
# Make dir if needed
# ------------------
filedir = opath.dirname(filepath)
os.makedirs(filedir, exist_ok=True)
try:
os.makedirs(filedir)
except OSError as error:
if error.errno != errno.EEXIST:
raise

# Write file
# ----------
Expand Down
7 changes: 6 additions & 1 deletion packages/python/plotly/plotly/io/_base_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
import webbrowser
import inspect
import os
import errno

import six
from plotly.io import to_json, to_image, write_image, write_html
Expand Down Expand Up @@ -564,7 +565,11 @@ def to_mimebundle(self, fig_dict):
filename = self.build_filename()

# Make directory for
os.makedirs(self.html_directory, exist_ok=True)
try:
os.makedirs(self.html_directory)
except OSError as error:
if error.errno != errno.EEXIST:
raise

write_html(
fig_dict,
Expand Down