Skip to content

Range slider second iteration (part 1) #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
etpinard merged 14 commits into from
Oct 6, 2016
Merged

Range slider second iteration (part 1) #962

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
a9b83bb
dragelement: export cover slip creator
etpinard Sep 21, 2016
b45f116
rangeslider: keep ref of input rangeslider container
etpinard Sep 21, 2016
dd1f9a3
rangeslider: refactor draw routine
etpinard Sep 21, 2016
1bb274b
rangeslider: rm (now useless) create_slider.js file
etpinard Sep 21, 2016
432f599
plot api: rm (now useless) range slider setRangeSliderRange
etpinard Sep 21, 2016
417435f
test: adapt range slider tests
etpinard Sep 21, 2016
74607d4
test: replace data-min / data-max in range slider tests
etpinard Sep 21, 2016
1d7b066
test: add range slider rrelayout test cases
etpinard Sep 21, 2016
c0ca4f5
test: add a little tolerance for FF
etpinard Sep 22, 2016
b062f0b
test: add toBeWithin jasmine matcher
etpinard Oct 5, 2016
8502206
test: use toBeWithin in range slider test
etpinard Oct 5, 2016
697ed3a
move range slider 'range' compute in update
etpinard Oct 6, 2016
b1155a3
book-keep range slider id
etpinard Sep 23, 2016
2a7696a
rangeslider: inherit 'bgcolor' from 'plot_bgcolor'
etpinard Oct 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/dragelement/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,8 @@ function coverSlip() {
return cover;
}

dragElement.coverSlip = coverSlip;

function finishDrag(gd) {
gd._dragging = false;
if(gd._replotPending) Plotly.plot(gd);
Expand Down
11 changes: 9 additions & 2 deletions src/components/rangeslider/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,12 @@ var attributes = require('./attributes');
module.exports = function handleDefaults(layoutIn, layoutOut, axName, counterAxes) {
if(!layoutIn[axName].rangeslider) return;

var containerIn = Lib.isPlainObject(layoutIn[axName].rangeslider) ?
layoutIn[axName].rangeslider : {},
// not super proud of this (maybe store _ in axis object instead
if(!Lib.isPlainObject(layoutIn[axName].rangeslider)) {
layoutIn[axName].rangeslider = {};
}

var containerIn = layoutIn[axName].rangeslider,
containerOut = layoutOut[axName].rangeslider = {};

function coerce(attr, dflt) {
Expand Down Expand Up @@ -48,4 +52,7 @@ module.exports = function handleDefaults(layoutIn, layoutOut, axName, counterAxe
layoutOut[ax] = opposing;
});
}

// to map back range slider (auto) range
containerOut._input = containerIn;
Copy link
Contributor

@mdtusz mdtusz Sep 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to delete containerIn._input before this to avoid a loop?

Copy link
Contributor Author

@etpinard etpinard Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what kind of loop are you referring to here?

Copy link
Contributor

@mdtusz mdtusz Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

containerOut._input = { 
  /* the containerIn */, 
  _input: { 
    /* the previous containerIn */, 
    _input: { 
      /* the previous conta...

Copy link
Contributor Author

@etpinard etpinard Oct 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_input is always linked to the layout as passed to Plotly.plot(gd, data, layout) - which doesn't know anything about containerOut.

};