Add deprecated warnings for pointcloud and heatmapgl #5447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Does look like this is the text that you see at the top of the docs for these traces. I wonder though, do we want to also include a console warning (once when you first create one of these traces) about the deprecation? I don't feel like people already using these traces will notice the deprecation in the docs, but they would (at least if they're using js directly) notice a console warning. @nicolaskruchten thoughts? How do you want to alert Python users? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing parts 2 and 3 here: #5395 (comment)
BTW am not 100% sure if this is the best place to put this warning?
@plotly/plotly_js