Skip to content

Fixup default angle of markers on scattermapbox #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
archmoj merged 2 commits into from
Apr 30, 2020
Merged

Fixup default angle of markers on scattermapbox #4794

archmoj merged 2 commits into from
Apr 30, 2020

Conversation

@archmoj
Copy link
Contributor

@archmoj archmoj commented Apr 30, 2020

The dflt for angle should be set to null not to zero.
Fixes
#4575 (comment)

@plotly/plotly_js

@archmoj archmoj added bug something broken status: reviewable regression this used to work labels Apr 30, 2020
@archmoj archmoj added this to the v1.54.0 milestone Apr 30, 2020
@archmoj archmoj requested a review from alexcjohnson April 30, 2020 18:59
@alexcjohnson
Copy link
Collaborator

alexcjohnson commented Apr 30, 2020

My concern with null is that it won’t set the attribute at all in fullData, which is a problem for RCE, it won't know that this attribute should be available. Perhaps we can use 'auto' as the default, and then strip it out before sending to the underlying mapbox library?

@archmoj
apply auto default
8654c38 
- fix fill for zero angles
- update angle description
alexcjohnson
alexcjohnson approved these changes Apr 30, 2020
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃 Excellent! Thanks for clarifying this behavior in the attribute description.

@archmoj archmoj merged commit 5227793 into master Apr 30, 2020
@archmoj archmoj deleted the scattermapbox-marker-angle-dflt branch April 30, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees

No one assigned

Labels

bug something broken regression this used to work

Projects

None yet

Milestone

v1.54.0

Development

Successfully merging this pull request may close these issues.

3 participants

@archmoj @alexcjohnson