Skip to content

Conversation

@etpinard
Copy link
Contributor

@etpinard etpinard commented Oct 24, 2018

I'm a big huge fan of @antoinerg 's #3136, so I couldn't resist improving it slightly.

This PR:

cc @plotly/plotly_js

@antoinerg
Copy link
Contributor

Thank you @etpinard :) I like your improvements as well 🎉

The only reason I had publish be the last build step was to have the following URL point to it:
https://circleci.com/api/v1.1/project/github/plotly/plotly.js/latest/artifacts?branch=master\&filter=successful. It turns out this was unreliable because latest could point to another job if the tests were still running. Therefore, it makes sense to run publish right after build!

💃

@etpinard etpinard merged commit 328bdd4 into master Oct 24, 2018
@etpinard etpinard deleted the etpinard-build-artifacts branch October 24, 2018 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants