Skip to content

add build artifact to CI build #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
antoinerg merged 10 commits into from
Oct 23, 2018
Merged

add build artifact to CI build #3136

Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
189f424
add build artifact to CI build
antoinerg Oct 22, 2018
0578160
update to circleci v2 api for artifacts
antoinerg Oct 22, 2018
8a8bbec
remove outdated circleci build artifact syntax
antoinerg Oct 22, 2018
243ed88
change plotly.js artifact destination
antoinerg Oct 22, 2018
d1806f8
store artifacts as last build step for easy retrieval with CircleCI API
antoinerg Oct 22, 2018
d02ce90
specify executor
antoinerg Oct 22, 2018
d54cf1a
properly checkout and attach to workspace
antoinerg Oct 22, 2018
bb9886e
fix typo in circleci config, make sure publish is the lastest build step
antoinerg Oct 22, 2018
3ebfa04
fix to make sure publish is last step
antoinerg Oct 23, 2018
82b640b
move test-image artifacts to root
antoinerg Oct 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ jobs:
command: ./.circleci/test.sh image
- store_artifacts:
path: build
destination: /

test-image2:
docker:
Expand All @@ -107,6 +108,7 @@ jobs:
command: ./.circleci/test.sh image2
- store_artifacts:
path: build
destination: /
Copy link
Contributor

@etpinard etpinard Oct 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch here 🎨


test-syntax:
docker:
Expand All @@ -120,6 +122,24 @@ jobs:
name: Run syntax tests
command: ./.circleci/test.sh syntax

publish:
docker:
- image: circleci/node:10.9.0
working_directory: ~/plotly.js
steps:
- checkout
- attach_workspace:
at: ~/plotly.js
- store_artifacts:
path: build/plotly.js
destination: /plotly.js
- store_artifacts:
path: dist/plotly.min.js
destination: /plotly.min.js
- store_artifacts:
path: dist/plot-schema.json
destination: /plot-schema.json

workflows:
version: 2
build-and-test:
Expand All @@ -140,3 +160,10 @@ workflows:
- test-syntax:
requires:
- build
- publish:
requires:
- test-jasmine
- test-jasmine2
- test-image
- test-image2
- test-syntax