+az (azure-cli)

[mfts]

closes #302

[what-the-diff]

• The package.yml file was added to the project
• It contains a list of dependencies, build instructions and test commands for azure-cli
• A new version is created from github tags by stripping off "azure-cli-" prefixes in each tag name
• Build script creates a virtual environment with python 3 installed and installs all required packages into it (including itself) using pip install command
• Test script runs an example command that shows information about AzureCloud cloud provider

[mfts]

The test is actually not working properly. It works locally on macOS. I guess it's something with the virtualenv. Will continue to check

[jhheider]

Does our existing python-venv.sh script not work for this?

[mfts]

no because in the root of the repo there's no setup.py. azure has three subrepos (see line 27-29)

[mfts]

It works locally, but I feel like something's not right here

[jhheider]

Hm. What if you ran them back-to-front:

for venv in azure-cli{-telemetry,-core,}; do
  python-venv.sh "{{prefix}}"/az
done

?

Just thinking that gets the most battle-testing in terms of venv management.

[mfts]

Doesn't work like that unfortunately, or I don't understand where you'd like to add it. We need some things that python-venv.sh is doing but not all

[jhheider]

Roger. I figure that'd build all three parts into the venv, and overwrite the final linkage each time; but if it's doesn't work, it doesn't work.

[mfts]

Ok I may have found a way:

for venv in azure-cli{-telemetry,-core,}; do
  SRCROOT={{prefix}}/../src-v{{version}}/src/"$venv" python-venv.sh "{{prefix}}"/bin/az
done

[jhheider]

Magical. I love standardization.

[mfts]

Cool it worked and tests pass too

[jhheider]

I think {{prefix}}/../src-v{{version}}/src/"$venv" is the same thing as ./src/"$venv".

[mfts]

throws an error if i do that

Error: invalid absolute path: ./src/azure-cli-telemetry
    at new Path (file:///opt/tea.xyz/src-v0.24.9/src/vendor/Path.ts:37:19)
    at from_env (file:///opt/tea.xyz/src-v0.24.9/src/app.ts:175:22)
    at injection (file:///opt/tea.xyz/src-v0.24.9/src/app.ts:165:16)
    at file:///opt/tea.xyz/src-v0.24.9/src/app.ts:34:36

[jhheider]

Hm. Guess that only works for TEA_PANTRY_PATH. Other packages (like tea.xyz/gx/cc) suggest that $SRCROOT might be set by default. I don't know if this better:

_SRCROOT="$SRCROOT"
for ......
   SRCROOT="$_SRCROOT"/src/"$venv" ...
...

That's not much of an improvement, but it protects against future changes.

[mfts]

I don't really understand this _SRCROOT="$SRCROOT" but it works :)

[jhheider]

Ha. Captures the original $SRCROOT before we start overwriting it.