+facebook.com/fb303#4379
Merged
Merged
Conversation
Contributor
Author
|
|
Contributor
brewkit v1! looks like maybe apache.org/thrift needs to be rebuilt with -fPIC... |
Contributor
|
because of the way brewkit^1 separates builds, i think this won't do it. probably need to rebuild it separately. |
cbf729d to
bdb3242
Compare
new file: projects/facebook.com/fb303/test.cpp
2d478e0 to
f54da6c
Compare
Contributor
|
wow, looks like it's there. |
jhheider
reviewed
Dec 22, 2023
| - -DCMAKE_EXE_LINKER_FLAGS=-pie | ||
| test: | ||
| dependencies: | ||
| facebook.com/fbthrift: '*' |
Contributor
There was a problem hiding this comment.
does it need fbthrift normally, or is that just for your test?
Contributor
Author
There was a problem hiding this comment.
does it need fbthrift normally, or is that just for your test?
based on the readme, it would be correct to include this dependency in the runtime section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #265