Skip to content

Ncurses fix paths & test#3121

Merged
jhheider merged 3 commits into
pkgxdev:mainfrom
and-ri:ncurses-fix-paths
Aug 26, 2023
Merged

Ncurses fix paths & test#3121
jhheider merged 3 commits into
pkgxdev:mainfrom
and-ri:ncurses-fix-paths

Conversation

@and-ri

@and-ri and-ri commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

This should fix the issue with libraries:
https://github.com/teaxyz/pantry/actions/runs/5986208701/job/16239342575?pr=2756

dyld[21426]: Library not loaded: @rpath/invisible-island.net/ncurses/v6.4.0/lib/libncursesw.6.dylib
  Referenced from: <0142D913-002E-3296-9E4B-D1D730514608> /Users/builder/.tea/macvim.org/v177.0.0/MacVim.app/Contents/MacOS/Vim
  Reason: tried: '/opt/invisible-island.net/ncurses/v6.4.0/lib/libncursesw.6.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/invisible-island.net/ncurses/v6.4.0/lib/libncursesw.6.dylib' (no such file), '/opt/invisible-island.net/ncurses/v6.4.0/lib/libncursesw.6.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/invisible-island.net/ncurses/v6.4.0/lib/libncursesw.6.dylib' (no such file), '/usr/local/lib/libncursesw.6.dylib' (no such file), '/usr/lib/libncursesw.6.dylib' (no such file, not in dyld cache)
Error: Process completed with exit code 1.

sed -i.bak 's|{{prefix}}|\${pcfiledir}/../..|g' {{prefix}}/lib/pkgconfig/*.pc
rm {{prefix}}/lib/pkgconfig/*.bak

sed -i.bak 's|{{prefix}}|\${NCURSES_ROOT}|g' {{prefix}}/bin/ncursesw{{version.major}}-config

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead creating a envvar, this should probably use the dirname dirname $0 logic we use in other places.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Yes it will be better. I'll do it now

@and-ri and-ri marked this pull request as ready for review August 26, 2023 21:27
@and-ri and-ri mentioned this pull request Aug 26, 2023
@jhheider jhheider merged commit fbba37b into pkgxdev:main Aug 26, 2023
@and-ri and-ri deleted the ncurses-fix-paths branch September 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants