Skip to content

mozilla.org/nss#2751

Merged
jhheider merged 24 commits into
pkgxdev:mainfrom
and-ri:new/mozilla.org/nss
Aug 24, 2023
Merged

mozilla.org/nss#2751
jhheider merged 24 commits into
pkgxdev:mainfrom
and-ri:new/mozilla.org/nss

Conversation

@and-ri

@and-ri and-ri commented Aug 6, 2023

Copy link
Copy Markdown
Contributor

closes #279

@and-ri and-ri force-pushed the new/mozilla.org/nss branch from 63228f3 to 8087ec8 Compare August 8, 2023 07:53
@and-ri and-ri marked this pull request as ready for review August 8, 2023 08:01
@and-ri

and-ri commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

I'm having trouble building this for darwin/aarch64.
I managed to make some progress using llvm clang but still run into the error aes-armv8.c:14:2: error: "Compiler option is invalid"
My mac architecture is x86-64 and I can't reproduce the error locally.
Perhaps you have some ideas?

@jhheider

jhheider commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Something makes me this -march=armv8-a -mfpu=crypto-neon-fp-armv8 isn't right.

For gnutls we had to do this: https://github.com/teaxyz/pantry/blob/577ffe507465e5b26411c39c951177e5e0b2c382/projects/gnutls.org/package.yml#L28-L34

Possibly force-settings arch/cpu/fpu options is the right move. Interesting that it doesn't build out of the box on aarch64, since Apple doesn't make any x86_64 devices any more.

@jhheider

Copy link
Copy Markdown
Contributor

Homebrew's recipe is against 3.87. Maybe see if that builds? This appears to be a mirror of it.

If that works, the release notes might be instructive for building later releases (versions: can be an array).

@jhheider

Copy link
Copy Markdown
Contributor

homebrew's comments make me think that firefox did some seriously non-standard stuff here. might have to branch out for other formulae for clues.

@and-ri

and-ri commented Aug 21, 2023

Copy link
Copy Markdown
Contributor Author

@jhheider maybe we can package it for linux only for now? This commit: a211990

chromedriver needs nss on linux

what do you think?

@jhheider

Copy link
Copy Markdown
Contributor

Releasing for Darwin for now with a comment seems fine.

@jhheider jhheider merged commit b07e2b5 into pkgxdev:main Aug 24, 2023
@and-ri and-ri deleted the new/mozilla.org/nss branch September 20, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

+nss (177/548)

2 participants