jmeter.apache.org#2730
Conversation
|
can we prefer eg. apache.org/jmeter for such things. I know it's not strictly the homepage, but that's not the primary reason for our namespacing scheme. I'm trying to keep the root namespace a little clearer. |
Yes sure |
| openjdk.org: '*' | ||
| runtime: | ||
| env: | ||
| JAVA_HOME: "{{prefix}}" |
There was a problem hiding this comment.
This seems wrong, the user can set this, we are overriding it.
There was a problem hiding this comment.
Hmm 🤔
perhaps it would be correct to check the existence of a variable and assign a value if it does not exist?
There was a problem hiding this comment.
why is it set? Add comments pls
There was a problem hiding this comment.
JAVA_HOME just resolve problem
The operation couldn’t be completed. Unable to locate a Java Runtime.
Please visit http://www.java.com/ for information on installing Java.
https://github.com/teaxyz/pantry/actions/runs/5743363132/job/15567693928
There was a problem hiding this comment.
Or maybe we can add JAVA_HOME in test section and add README.md with information that JAVA_HOME must be set in env?
There was a problem hiding this comment.
Shouldn't JAVA_HOME be ${{deps.openjdk.org.prefix}}, and exported from that package? Per my limited recollection of configuring Java. @ABevier was a Javanista: any thoughts on this?
There was a problem hiding this comment.
Yes, the final version is {{deps.openjdk.org.prefix}}
There was a problem hiding this comment.
Right. But shouldn't that be in the runtime of openjdk.org, not packages that depend on it?
There was a problem hiding this comment.
Right. But shouldn't that be in the runtime of
openjdk.org, not packages that depend on it?
Yes, I had thoughts of doing this too. I made changes to this pull request
#2727
closes #698