+aws-sdk-cpp#1828
Conversation
PR Summary
|
|
seems like this is gonna be a fun one. there's a submodule that's not included in the tarball. and since there's no .git directory, it's not clear what commit of the submodule is needed. and it's recursive, so the submodule has submodules. https://github.com/aws/aws-sdk-cpp/blob/main/.gitmodules I could imagine just cloning the repo instead of grabbing the tarball. or using the github api to figure out the submodule commit hash, then cloning the correct commit. or getting the commit and then getting a tarball, but you'd have to do that recursively. I searched for "submodule" in the pantry repo and didn't see any existing references, so I dunno if this case has come up yet. |
|
I think the submodule issue here likely needs to be solved by: pkgxdev/brewkit#111 |
this works with the upcoming brewkit 0.31.0
|
the fixes added work for me with the upcoming brewkit 0.31.0. recommend renaming to |
|
there we go |
|
Still marked as draft. Deliberate? |
|
gonna go ahead and merge this. we can open for new work if needed. |
|
sorry, got a bit sidetracked by work and life. thanks for the followup. I'll try to get to my other straggling PR drafts this week. btw @jhheider packaging up the git repo as a tarball so it would "just work" with the rest of the brewkit code was pretty clever. when I was looking at the code that's where I got kinda overwhelmed by the changes that would have been needed without that trick. |
closes #545