Stack trace incorrect in go 1.12

[uberbo]

Simplest way to reproduce:

package main

import (
	"fmt"
	"github.com/pkg/errors"
)

func main() {
	fmt.Printf("%+v\n", errors.New("fail fast"))
}

Output:

Wrong file name for main.main and includes skipPleaseUseCallersFrames:

fail fast
main.main
	/gocode/src/github.com/pkg/errors/errors.go:104
runtime.skipPleaseUseCallersFrames
	/sdk/go1.12beta1/src/runtime/asm.s:40
runtime.main
	/sdk/go1.12beta1/src/runtime/proc.go:200
runtime.goexit
	/sdk/go1.12beta1/src/runtime/asm_amd64.s:1337

Using

go version go1.12beta1 darwin/amd64

Expected output

fail fast
main.main
	/gocode/src/playground/go12betapkgerrors/main.go:9
runtime.main
	/usr/local/Cellar/go/1.11.4/libexec/src/runtime/proc.go:201
runtime.goexit
	/usr/local/Cellar/go/1.11.4/libexec/src/runtime/asm_amd64.s:1333

Related: golang/go#29526 (comment)

[davecheney]

Thank you for raising this issue. I'm hoping to have this fixed by the time 1.12 is released.

…

On Thu, 3 Jan 2019 at 22:35, Bo Sunesen ***@***.***> wrote: See golang/go#29526 (comment) <golang/go#29526 (comment)> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#180>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAcAx7MHg30ZzecArh-3j0PY_qS_E3Vks5u_erqgaJpZM4Zn8b6> .

[davecheney]

Fixed in #183