Add explicit error handling for battle sprites of unexpected sizes#349
Open
PhoenixBound wants to merge 1 commit into
Open
Add explicit error handling for battle sprites of unexpected sizes#349PhoenixBound wants to merge 1 commit into
PhoenixBound wants to merge 1 commit into
Conversation
An exception with an actual CoilSnake-specific error message mentioning the problematic sprite is now raised, instead of Python raising one incidentally with a bad error mesage. Tested within coilsnake-cli, not the GUI version of CoilSnake, but all of that should work about the same way. Fixes pk-hack#343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception with an actual CoilSnake-specific error message mentioning the problematic sprite is now raised.
Fixes #343 (in a way that feels better than the minimal solution mentioned in the issue)