Conversation
|
@aars not sure if I mentioned it to you yet, I often use a test repo for manually testing too, see - https://github.com/pixelhandler/jr-test I think the dummy app works in this repo for testing, but needed an app that is actually consuming the addon (aside from dummy app behavior). If you have time would you consider some updates on the |
| @class AdapterApiHostProxyMixin | ||
| @static | ||
| */ | ||
| export default Ember.Mixin.create({ |
There was a problem hiding this comment.
My pleasure. When I find the time I'll look through all the docs. Those needs some touching up I reckon.
|
@aars would you mind making one change to keep the config import in the blueprint? |
|
@pixelhandler I messed up with the config import statement yeah. When the blueprint fix/tests get merged we can add some more specific blueprint tests to catch this. |
|
@pixelhandler One "major" change in here is the reversal of I thought it made more sense to define the |
This PR includes:
urlfrom blueprint (usesAPI_HOSTas well asAPI_PATH).urlthrough computed property (when not using generatedurl).AdapterApiHostProxyMixinto keep example usage ofAPI_HOST_PROXYin addon.fetchUrlimplementation from adapter blueprinturl = url.replace(proxy, host);!???? Was that supposed to be like that?I've tried setting up the tests in an appropriate
tests/unit/mixinsfile but I failed to get it running (missing owner, container, registry, etc). Test is added to adapter's unit test.