This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Conversation
e5e14bc to
476983b
Compare
Fix behavior for rollbackAttributes. The intent is to rollback to the value fetched from the persistence layer; not to stash an attribute’s value on every call to `.set()`. - Fix failing tests for previousAttributes and rollbackAttributes - Update `attr()` `set()` method to only assign to `.previous` once
476983b to
25e7fd7
Compare
Owner
Author
|
@realityendshere Here is the PR to fix the rollback behavior. Thanks for the failing tests :) |
Owner
Author
|
@realityendshere this is included in ember-jsonapi-resources@2.0.3 now tag/2.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix behavior for rollbackAttributes. The intent is to rollback to the value fetched from the persistence layer; not to stash an attribute’s value on every call to
.set().attr()set()method to only assign to.previousonce