This repository was archived by the owner on Jan 22, 2026. It is now read-only.
Failing tests for previousAttributes/rollbackAttributes#133
Merged
pixelhandler merged 1 commit intopixelhandler:masterfrom Jan 13, 2017
Merged
Conversation
…rollbackAttributes
Current behavior is to stash an attribute’s value on EVERY call to .set(). The intent seems to be to rollback to the value fetched from the persistence layer.
As illustrated by the tests:
```
post.get(‘excerpt’); // ‘Was a gambler.’
post.set('excerpt', 'Became the sheriff.');
post.set('excerpt', 'Became the chief.');
post.set('excerpt', 'Became the mayor.');
post.get('previousAttributes.excerpt’); // 'Became the chief.'
```
The previous value is simply the previous change ('Became the chief’) instead of the “original” value (“Was a gambler”).
The new tests FAIL to show that “previousAttributes” and “rollbackAttributes” to not behave as expected.
504eeec to
1c8a7db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current behavior is to stash an attribute’s value on EVERY call to .set(). The intent seems to be to rollback to the value fetched from the persistence layer.
As illustrated by the tests:
The previous value is simply the previous change ('Became the chief’) instead of the “original” value (“Was a gambler”).
The new tests FAIL to show that “previousAttributes” and “rollbackAttributes” to not behave as expected.