Remove deprecated Ember.K#132
Remove deprecated Ember.K#132pixelhandler merged 2 commits intopixelhandler:masterfrom cibernox:remove-deprecated-ember-k
Conversation
| mockFetchJax(sandbox, adapter, postMock); | ||
| sandbox.stub(adapter, 'cacheResource', function () {}); | ||
| adapter.serializer = { deserialize: sandbox.spy(), deserializeIncluded: Ember.K }; | ||
| adapter.serializer = { deserialize: sandbox.spy(), deserializeIncluded() {} }; |
There was a problem hiding this comment.
@cibernox nice, thanks for the fix. So named function declaration in shorthand syntax . Sweet. deserializeIncluded() {} and clean
|
@cibernox looks like the Travis build fails. I'll take a look over the weekend. |
|
Actually this PR was made with an automatic tool that does all the transformations automatically https://github.com/cibernox/ember-k-codemod I'm working on a script that it's going to fix every open source addon automatically, because after 3/4 pull requests this is boring. |
|
@cibernox I've been interested in creating code mods for things like blueprint upgrades, e.g. many files generated with a blueprint and then upgrading the blueprint and providing a codemode to migrate existing (generated) files. |
|
It is fun indeed, but beware, documentation is scarce. It's mostly a matter of trial and error (and a lot of debuggers) |
|
@cibernox one way "I cut my teeth" (learning) programming was writing code mods for phpMyBB, the format was like find |
|
@cibernox I added a commit to fixup an unused Ember import in a test. |
| @@ -1,4 +1,3 @@ | |||
| import Ember from 'ember'; | |||
There was a problem hiding this comment.
@cibernox after removing Ember.K the import was no longer needed.
Ember.Khas been deprecated in Ember.