Skip to content

Support configuring the Jackson Object Mapper #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lorrin wants to merge 2 commits into from
Closed

Support configuring the Jackson Object Mapper #376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f97b923
Support configuring the Jackson Object Mapper
lorrin Jul 10, 2017
ffdc51d
Back out superflous accessor
lorrin Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions ...o-content-type-parent/pippo-jackson/src/main/java/ro/pippo/jackson/JacksonBaseEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
import com.fasterxml.jackson.module.afterburner.AfterburnerModule;
import ro.pippo.core.Application;
import ro.pippo.core.ContentTypeEngine;
import ro.pippo.core.HttpConstants;
import ro.pippo.core.PippoRuntimeException;

import java.io.IOException;
Expand All @@ -36,17 +35,17 @@
*/
public abstract class JacksonBaseEngine implements ContentTypeEngine {

protected ObjectMapper objectMapper;
private ObjectMapper objectMapper;

@Override
public void init(Application application) {
objectMapper = getObjectMapper();
objectMapper = createObjectMapper();
objectMapper.configure(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS, false);
objectMapper.setTimeZone(TimeZone.getDefault());
objectMapper.registerModule(new AfterburnerModule());
}

protected abstract ObjectMapper getObjectMapper();

@decebals decebals Jul 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's enough to make this method public.

protected abstract ObjectMapper createObjectMapper();

@Override
public String toString(Object object) {
Expand Down
2 changes: 1 addition & 1 deletion ...o-content-type-parent/pippo-jackson/src/main/java/ro/pippo/jackson/JacksonJsonEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
public class JacksonJsonEngine extends JacksonBaseEngine {

@Override
protected ObjectMapper getObjectMapper() {
protected ObjectMapper createObjectMapper() {
return new ObjectMapper();
}

Expand Down
2 changes: 1 addition & 1 deletion pippo-content-type-parent/pippo-jackson/src/main/java/ro/pippo/jackson/JacksonXmlEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
public class JacksonXmlEngine extends JacksonBaseEngine {

@Override
protected ObjectMapper getObjectMapper() {
protected ObjectMapper createObjectMapper() {
// Check out: https://github.com/FasterXML/jackson-dataformat-xml
JacksonXmlModule module = new JacksonXmlModule();
// setDefaultUseWrapper produces more similar output to
Expand Down
2 changes: 1 addition & 1 deletion ...o-content-type-parent/pippo-jackson/src/main/java/ro/pippo/jackson/JacksonYamlEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
public class JacksonYamlEngine extends JacksonBaseEngine {

@Override
protected ObjectMapper getObjectMapper() {
protected ObjectMapper createObjectMapper() {
return new YAMLMapper();
}

Expand Down