fix(web): fully clear diff route state when closing panel

[copypasteitworks]

Summary

This also targets the diff-panel close bug addressed in #937. I noticed that PR after preparing this one, so if that approach is preferred this PR can be closed.

This affects both browser and desktop builds because the diff panel state is driven by the same web route/search logic.

This version differs in two ways:

• it clears the full diff route state on close, not just diff
• it adds a focused regression test for removing diff search state from the active thread route

Closes #931
Closes #935

Repro

1. Open a thread.
2. Open the diff panel.
3. Try to close it with the close button.
4. On narrow layouts, try dismissing it by clicking the overlay.

Actual on main

The route keeps diff=1, so the diff panel does not really close.

Root Cause

The thread route retains the diff search param at the route level, so explicit close navigation that strips diff params is immediately overridden by retained search state.

What This Changes

• removes route-level diff search retention from the thread route
• keeps shared diff search validation through the thread route search options
• adds a regression test proving stripDiffSearchParams(previous) removes diff route state from the active thread route

Why This Differs From #937

#937 fixes the stuck-open symptom by unsetting diff, but leaves diffTurnId and diffFilePath behind.

This PR clears all diff route params on close, which keeps the URL and route state fully in sync after dismissing the panel.

Testing

• bun fmt
• bun lint
• bun typecheck
• bun run test -- src/threadRouteSearch.test.ts
• manually verified on main that:
  • close button does not close the diff panel
  • overlay dismiss does not close the diff panel on narrow layouts
• manually verified on this branch that both close paths work

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: a4308e8b-8169-4f1d-a274-c72c33e1d00a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[ByQwank]

Merge already!! this has been driving me nuts today

[aashishsingla567]

Can we merge either this or the other fix? its very annoying.

[juliusmarminge]

fixed