fix: fix unclosable diff panel#930
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@atharvadeosthale, could you please add closing tag |
chuks-qua
left a comment
There was a problem hiding this comment.
remove out of scope change
apps/web/public/mockServiceWorker.js
Outdated
| */ | ||
|
|
||
| const PACKAGE_VERSION = '2.12.9' | ||
| const PACKAGE_VERSION = '2.12.10' |
There was a problem hiding this comment.
@atharvadeosthale could you revert this change please
There was a problem hiding this comment.
@chuks-qua This was not a manual change - is it okay to revert regardless?
There was a problem hiding this comment.
best to revert and leave changes like these for theo or julius, they prefer to maintain things like this
|
closing in favor of #937 (sorry) |
What Changed
Fixed unclosable diff panel
Why
Because it'd open and never close again
Closes #931
UI Changes
Before
Clipboard-20260311-185852-849.mp4
After
T3.Code.Alpha.mp4
Checklist
Note
Fix unclosable diff panel by clearing diff query params and adding click-outside handler
clearDiffSearchParamsin diffRouteSearch.ts that explicitly setsdiff,diffTurnId, anddiffFilePathtoundefined(rather than omitting them), ensuring TanStack Router removes the params from the URL.onToggleDiffin ChatView.tsx andcloseDiffin _chat.$threadId.tsx to useclearDiffSearchParamsinstead ofstripDiffSearchParams.DiffPanelInlineSidebarthat closes the diff panel on click-outside, and raises the sidebar's z-index withz-20.Macroscope summarized e660ba0.