Skip to content

fix: fix unclosable diff panel#930

Closed
atharvadeosthale wants to merge 3 commits intopingdotgg:mainfrom
atharvadeosthale:fix-unclosable-drawer
Closed

fix: fix unclosable diff panel#930
atharvadeosthale wants to merge 3 commits intopingdotgg:mainfrom
atharvadeosthale:fix-unclosable-drawer

Conversation

@atharvadeosthale
Copy link
Copy Markdown

@atharvadeosthale atharvadeosthale commented Mar 11, 2026

What Changed

Fixed unclosable diff panel

Why

Because it'd open and never close again

Closes #931

UI Changes

Before

Clipboard-20260311-185852-849.mp4

After

T3.Code.Alpha.mp4

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Fix unclosable diff panel by clearing diff query params and adding click-outside handler

  • Introduces clearDiffSearchParams in diffRouteSearch.ts that explicitly sets diff, diffTurnId, and diffFilePath to undefined (rather than omitting them), ensuring TanStack Router removes the params from the URL.
  • Updates onToggleDiff in ChatView.tsx and closeDiff in _chat.$threadId.tsx to use clearDiffSearchParams instead of stripDiffSearchParams.
  • Adds a full-screen transparent overlay in DiffPanelInlineSidebar that closes the diff panel on click-outside, and raises the sidebar's z-index with z-20.

Macroscope summarized e660ba0.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 662b3c0e-8ef5-464b-9ec4-77e19900f431

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:unvouched PR author is not yet trusted in the VOUCHED list. label Mar 11, 2026
@chuks-qua
Copy link
Copy Markdown
Contributor

@atharvadeosthale, could you please add closing tag
closes #931

Copy link
Copy Markdown
Contributor

@chuks-qua chuks-qua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove out of scope change

*/

const PACKAGE_VERSION = '2.12.9'
const PACKAGE_VERSION = '2.12.10'
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atharvadeosthale could you revert this change please

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chuks-qua This was not a manual change - is it okay to revert regardless?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

best to revert and leave changes like these for theo or julius, they prefer to maintain things like this

@maria-rcks
Copy link
Copy Markdown
Collaborator

closing in favor of #937 (sorry)

@maria-rcks maria-rcks closed this Mar 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Diff panel toggle doesn't hide the diff panel

3 participants