Skip to content

fix(web): preserve historical tool styling in chat history#905

Open
binbandit wants to merge 3 commits intopingdotgg:mainfrom
binbandit:t3code/fix-chat-history-styling-regression
Open

fix(web): preserve historical tool styling in chat history#905
binbandit wants to merge 3 commits intopingdotgg:mainfrom
binbandit:t3code/fix-chat-history-styling-regression

Conversation

@binbandit
Copy link
Copy Markdown
Contributor

@binbandit binbandit commented Mar 11, 2026

Summary

  • keep historical tool and work rows visible after a later turn becomes the latest turn
  • cover the timeline projection change with unit and browser regressions for the history-to-new-turn transition

Validation

  • bun run fmt
  • bun run lint
  • bun run typecheck
  • bun run test src/session-logic.test.ts
  • bun run test:browser src/components/ChatView.browser.tsx

Note

Preserve historical tool rows in chat timeline after a new user turn starts

  • deriveWorkLogEntries in session-logic.ts now accepts an optional turnId filter; when omitted, it returns work entries across all turns instead of filtering to the active turn.
  • ChatView no longer passes activeLatestTurn?.turnId to deriveWorkLogEntries, so the timeline includes tool/work entries from prior turns.
  • A browser test verifies that historical tool rows remain visible after a new latest turn is added to the store.

Macroscope summarized 943afd5.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 11, 2026

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: df1f729b-3010-4d44-9211-a01d8fa591d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added the vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. label Mar 11, 2026
@zortos293
Copy link
Copy Markdown
Contributor

This is more complete version of the one that i did and should be merged asap

@zortos293
Copy link
Copy Markdown
Contributor

I couldn’t find a issue/pr specifically for this problem none has been reported yet

@maria-rcks
Copy link
Copy Markdown
Collaborator

yeah looks like there isnt any

@binbandit
Copy link
Copy Markdown
Contributor Author

maybe im just super good at seeing tiny problems 🤷‍♀️

@github-actions github-actions bot added the size:L 100-499 changed lines (additions + deletions). label Mar 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-julius size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants