Skip to content

Fix desktop chat markdown external links #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CodeZeno wants to merge 1 commit into from
Closed

Fix desktop chat markdown external links #623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 26 additions & 1 deletion apps/web/src/components/ChatMarkdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import React, {
import type { Components } from "react-markdown";
import ReactMarkdown from "react-markdown";
import remarkGfm from "remark-gfm";
import { isElectron } from "../env";
import { resolveDiffThemeName, type DiffThemeName } from "../lib/diffRendering";
import { fnv1a32 } from "../lib/diffRendering";
import { LRUCache } from "../lib/lruCache";
Expand Down Expand Up @@ -240,7 +241,31 @@ function ChatMarkdown({ text, cwd, isStreaming = false }: ChatMarkdownProps) {
a({ node: _node, href, ...props }) {
const targetPath = resolveMarkdownFileLinkTarget(href, cwd);
if (!targetPath) {
return <a {...props} href={href} target="_blank" rel="noreferrer" />;
if (!isElectron) {
return <a {...props} href={href} target="_blank" rel="noreferrer" />;
}

return (
<a
{...props}
href={href}
target="_blank"
rel="noreferrer"
onClick={(event) => {
if (!href) {
return;
}
const api = readNativeApi();
if (api) {
event.preventDefault();
event.stopPropagation();
void api.shell.openExternal(href);
} else {
console.warn("Unable to open external link.");
}
}}
/>
);
}

return (
Expand Down